Skip to content

Instantly share code, notes, and snippets.

@wbamberg
Last active December 15, 2015 13:19
Show Gist options
  • Save wbamberg/5266250 to your computer and use it in GitHub Desktop.
Save wbamberg/5266250 to your computer and use it in GitHub Desktop.
Hi
As you might already know, Firefox 20 makes a major change in the
way private-browsing is implemented, and this inevitably affects
add-ons that use it.
Add-ons that use private-browsing must be repacked with SDK 1.14
if they are to run on Firefox 20, and need code updates if they
are to be able to see private windows.
See this blog post for more details, and the 1.14 private-browsing
docs for more on how to use the new APIs.
I've been going through the add-ons hosted on AMO that use
private-browsing, trying to work out what needs to happen for them
to work with Firefox 20/Add-on SDK 1.14.
In the case of your add-on "open-private-browsing", it won't work on
Firefox 20 without code updates: this is because in SDK 1.14 onwards,
add-ons have to explicitly opt into private browsing if they want to
see or open private windows.
***
We will mark the version of your add-on on AMO as incompatible with
Firefox 20. You'll need to update the code and resubmit the add-on for
review, and we'll try to get the review done as quickly as possible.
***
If you have any questions, please don't hesitate to ask me, or ask
on the Jetpack group.
Thanks!
Will
@jeffgca
Copy link

jeffgca commented Mar 28, 2013

I've made edits over here, nothing major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment