WeekSevenHomework

//My homework choice is AccountTriggerGood:
//This is a better example of a trigger. It uses a trigger handler to carry out business logic,
//and it only accepts parameters that have related trigger handlers. It also doesn't have unused if/else statements.
//As a developer works on this trigger in the future, they can easily see when they're writing new trigger logic, or expanding
//on existing logic because the trigger is readable and doesn't have unsued code just hanging out.

trigger AccountTriggerGood on Account (before insert, before update, after insert, after update) {
    
    // First, we have a simpler if/else if block separating inserts from updates 
    // This helps trigger performance and keeps triggers with lots of handlers more readable
    if (Trigger.isInsert) {
        if(Trigger.isBefore){
            AccountTriggerHandler.handleBeforeInsert(Trigger.new);
        } else if(Trigger.isAfter){
            AccountTriggerHandler.handleAfterInsert(Trigger.new);
        }
        
    } else if (Trigger.isUpdate){
        //we don't have any business logic for before updates, so we don't need to have an unused if statement
        if(Trigger.isAfter){
            AccountTriggerHandler.handleAfterUpdate(Trigger.new, Trigger.oldMap);
        }
    }
    //future trigger logic blocks here

}

public with sharing class AccountTriggerHandler {
    
    public static void handleBeforeInsert(List<Account> newAccounts){
        for (Account a : newAccounts) {
            if (a.Est_Annual_Sales__c >= 5000000) {
                a.Priority__c = 'Highest';
            } else if (a.Est_Annual_Sales__c >= 3000000) {
                a.Priority__c = 'High';
            } else if (a.Est_Annual_Sales__c >= 1000000) {
                a.Priority__c = 'Standard';
            } else {
                a.Priority__c = 'Low';
            }
        }
        //this is a before trigger, so our handler doesn't have to call DML
    }

    public static void handleAfterInsert(List<Account> newAccounts){
        
        Id runningUserId = UserInfo.getUserId();
        //Get the email address for the Account owner
        User u = [SELECT Id, Email FROM User WHERE Id = :runningUserId];
        //Week 7 Homework - bulkify this code
        
        List<Case> newCaseList = new List<Case>();
        for (Account a : newAccounts) {
            Case c = new Case();
            c.Status = 'New';
            c.Origin = 'New Account'; //Make sure you've added this as a picklist value for this field
            c.Subject = 'Send Welcome Package';
            c.AccountId = a.Id;
            c.Description = 'Please follow up with this new Account and send them a Welcome Package.';
            c.Staff_Email_Address__c = u.Email;
            newCaseList.add(c);
        }
        if(newCaseList.size()>0){
        insert newCaseList
        }

    public static void handleAfterUpdate(List<Account> acctsForUpdate, Map<Id, Account> oldAcctMap){
        //First thing we do is query for all the opportunities on accounts involved in this trigger
        //The SOQL query below uses a nested query, this let's us pull back each acccount with a list of its opportunities attached.
        //We won't be covering nested queries in this class, but take a look and see if you can figure out how they work
        Map<Id, Account> acctsWithOpps = new Map<Id, Account>(
            [SELECT Id, (SELECT Id FROM Opportunities WHERE IsClosed = false) FROM Account WHERE Id IN :acctsForUpdate]
        );

        //Let's make a list to hold any opportunities we create for later insertion
        List<Opportunity> newOpportunities = new List<Opportunity>();

        //Now we need to loop through the accounts in this trigger and see if their priority has been changed in the way we're looking for
        for (Account updatedAcct : acctsForUpdate) {

            //ok, so now we have the udpated Account record, but we also need to compare it to the old version to see what has changed
            //We can use the oldAccountMap, pass it the Account Id, and we'll get the old version for comparison
            Account oldAcct = oldAcctMap.get(updatedAcct.Id);

            //ok, now we have the new and old versions of the same record and we can make our comparison
            if ((oldAcct.Priority__c != 'Highest' && oldAcct.Priority__c != 'High') && (updatedAcct.Priority__c == 'Highest' || updatedAcct.Priority__c == 'High')) {
                //we have a winner!  now check and see if the account has any Open Opportunities

                System.debug('Number of Opportunities on this Account' + acctsWithOpps.get(updatedAcct.Id).Opportunities.size());

                if (acctsWithOpps.get(updatedAcct.Id).Opportunities.size() == 0) {
                    //Ok, this account has no open opportunities, let's create one
                    Opportunity opp = new Opportunity();
                    opp.Name = updatedAcct.Name + ' Opportunity';
                    opp.StageName = 'Prospecting';
                    opp.CloseDate = Date.today().addMonths(3);
                    opp.AccountId = updatedAcct.Id;
                    newOpportunities.add(opp);
                }
            }
        }

        //Finally, insert any new Opportunities
        if (newOpportunities.size() > 0) {
            insert newOpportunities;
        }

    }

}

Hi Una, you're almost there! You saw that you needed to move the SOQL out of the for-loop, and you created the list to add your new cases into. BUT... you forgot the DML statement to save the list of new cases. Can you go back and add that?

Thank you very much for pointing it out. I have added the Line63-65 hope I did it right lol