Created
August 27, 2017 13:21
-
-
Save ptvirgo/31449b864175d2e2e55cd8a658dff2a6 to your computer and use it in GitHub Desktop.
I caught a rude character interfering with my data migration...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#!/usr/bin/env python | |
# -*- coding: utf-8 -*- | |
import unittest | |
RUDE = b"\xe3\x80\x82".decode("utf-8") | |
def limit_slice(maxlen, text): | |
"""Given a maximum length and text, return the text truncated to the provided | |
length.""" | |
encoded = text.encode("utf-8", errors="replace")[:maxlen] | |
return encoded.decode("utf-8", errors="replace") | |
def limit_count(maxlen, text): | |
"""Given a maximum length and text, return the text truncated to the provided | |
length.""" | |
truncated = "" | |
tl = 0 | |
for c in text: | |
size = len(c.encode("utf-8")) | |
if tl + size <= maxlen: | |
truncated += c | |
tl += size | |
else: | |
break | |
return truncated | |
class TestLimits(unittest.TestCase): | |
def test_slicing(self): | |
testlen = 8 | |
truncated = limit_slice(testlen, "Hello " + RUDE + " world") | |
self.assertTrue(len(truncated.encode("utf-8")) <= testlen) | |
def test_count(self): | |
testlen = 8 | |
truncated = limit_count(testlen, "Hello " + RUDE + " world") | |
self.assertTrue(len(truncated.encode("utf-8")) <= testlen) | |
if __name__ == "__main__": | |
unittest.main() |
Yeah, this isn’t a python thing, I think it’s a character encoding thing. If your target data store is limiting you in bytes, you’re actually doing this wrong. When you use utf8 you explicitly give up the assumption that a character is the same size as a byte. I think you need to truncate to the byte length, but be aware of characters. Maybe a function that chops off a character while the string—interpreted as a byte array, not characters—is too long.
(Sorry for the delay)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This probably looks coerced.
For context - the original code is migrating millions of records from a MongoDB to Google Datastore. The byte limitation rules for Datastore are strict. Submitting a batch of records where a single field has a single byte out of range causes an exception and the data is discarded. Truncation of the fields in question is acceptable.
My naive guess is that under the hood of the "slice" version, Python is doing something like
while length < max_length: append next character
. It's probably better than that, because ...errors="replace"
, but I'm in the position of speculating.I wonder what someone more experienced with Python internals and byte-level operations would say?