Last active
March 31, 2023 16:41
-
-
Save mshoaibshafi/c6aba2070dc67562223479ed21db6846 to your computer and use it in GitHub Desktop.
Terraform update in place after changing the list item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Terraform keep updating-in-place resources even though none of them got touched instead of their position has changed ... can someone help me fix this issue - | |
.... < remove some extra info > ... | |
Terraform used the selected providers to generate the following execution plan. Resource actions are | |
indicated with the following symbols: | |
~ update in-place | |
Terraform will perform the following actions: | |
# aws_iam_user_group_membership.groups["0"] will be updated in-place | |
~ resource "aws_iam_user_group_membership" "groups" { | |
~ groups = [ | |
- "aws-lambda", | |
+ "aws-ec2", | |
] | |
id = "terraform-20230331153935663300000002" | |
# (1 unchanged attribute hidden) | |
} | |
# aws_iam_user_group_membership.groups["1"] will be updated in-place | |
~ resource "aws_iam_user_group_membership" "groups" { | |
~ groups = [ | |
- "aws-ec2", | |
+ "aws-vpc", | |
] | |
id = "terraform-20230331153935663300000003" | |
# (1 unchanged attribute hidden) | |
} | |
# aws_iam_user_group_membership.groups["2"] will be updated in-place | |
~ resource "aws_iam_user_group_membership" "groups" { | |
~ groups = [ | |
- "aws-vpc", | |
+ "aws-lambda", | |
] | |
id = "terraform-20230331154455701300000002" | |
# (1 unchanged attribute hidden) | |
} | |
Plan: 0 to add, 3 to change, 0 to destroy. | |
Here is the detail and tasks required : | |
1. Create AWS IAM users and AWS IAM Groups | |
2. Assign users to groups as per their role | |
Issue : when the order of the groups changed, Terraform detect it unnecessarily and try to update the state file | |
Below is a “one-file.tf” below is the two YAML files to for users.yaml & groups.yaml | |
# Local variables | |
locals { users = yamldecode(file("users.yaml")) } | |
locals { groups = yamldecode(file("groups.yaml")) } | |
# Create iam user | |
resource "aws_iam_user" "users" { | |
for_each = local.users | |
name = each.value.name | |
} | |
# Create iam group | |
resource "aws_iam_group" "groups" { | |
for_each = local.groups | |
name = each.value.name | |
} | |
# Users can have multiple groups | |
# Flatten user > group for group-assignments | |
locals { | |
groupAssignments = flatten([ | |
for key, attributes in local.users : [ | |
for g in attributes.groups : { | |
name = attributes.name | |
group = g | |
email = key | |
} | |
] | |
]) | |
} | |
# Assign Users to Group | |
resource "aws_iam_user_group_membership" "groups" { | |
for_each = { for idx, v in local.groupAssignments : idx => v } | |
user = aws_iam_user.users[each.value.email].name | |
groups = [aws_iam_group.groups[each.value.group].name] | |
} | |
## Provider | |
terraform { | |
required_providers { | |
aws = { | |
source = "hashicorp/aws" | |
version = "4.59.0" | |
} | |
} | |
} | |
provider "aws" {} | |
=== users.yaml === | |
[email protected]: | |
name: "ali" | |
groups: | |
- aws-lambda | |
- aws-ec2 | |
- aws-vpc | |
=============== | |
== groups.yaml === | |
"aws-ec2": | |
name: aws-ec2 | |
"aws-lambda": | |
name: aws-lambda | |
"aws-ecs": | |
name: aws-ecs | |
"aws-vpc": | |
name: aws-vpc | |
================ | |
The issue occurred if you change the order of the group in a "users.yaml" as | |
=== modified users.yaml === | |
[email protected]: | |
name: "ali" | |
groups: | |
- aws-ec2 | |
- aws-vpc | |
- aws-lambda | |
=============== |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment