Last active
February 27, 2017 21:57
-
-
Save mkresin/caad96a62aad4dee0492fc6abfa23ccd to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please use ```git commit --amend``` to add changes to your commit. Use ```git push --force``` to overwrite your github repository/branch. The PR will afterwards update automatically. Please don't close this PR and open a new one. | |
--- | |
Please include <[dt-bindings/gpio/gpio.h](http://lxr.free-electrons.com/source/include/dt-bindings/gpio/gpio.h?v=4.4)> here as well and keep alphabetical order.. | |
Use the GPIO_ACTIVE_LOW and GPIO_ACTIVE_HIGH macros afterwards in stead of 1 and 0 in the gpio parameters. | |
Check the recent [ramips board additions](https://github.com/lede-project/source/commits/master/target/linux/ramips) for examples. | |
--- | |
Please, include a short description about the device you are adding support for and how to flash a LEDE image to the commit message of the support commit. Have a look at https://github.com/lede-project/source/commit/3f31029b190417e12f4d19d9999cd52ec76d0f85 for an good example. Please also mention in the commit message what is not (yet) working. | |
--- | |
Your commit has formal issues. Please have a look at [draft version of the github submission guidelines](https://github.com/bobafetthotmail/source/blob/68913cbafbd7b16f9819c5b29db3cda307a79b30/.github/pull_request_template) and the [generic submission guidelines](https://lede-project.org/docs/guide-developer/the-source-code#submitting_patches). | |
- no signed of by line | |
- no commit message | |
- wrong/missing prefix in commit title | |
Please have a look at the LEDE commit history to have some examples on how to do it the right way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment