Created
July 12, 2012 16:50
-
-
Save matthewp/3099268 to your computer and use it in GitHub Desktop.
XMLHttpRequest wrapped into a promise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function xhr(options) { | |
var deferred = Q.defer(), | |
req = new XMLHttpRequest(); | |
req.open(options.method || 'GET', options.url, true); | |
// Set request headers if provided. | |
Object.keys(options.headers || {}).forEach(function (key) { | |
req.setRequestHeader(key, options.headers[key]); | |
}); | |
req.onreadystatechange = function(e) { | |
if(req.readyState !== 4) { | |
return; | |
} | |
if([200,304].indexOf(req.status) === -1) { | |
deferred.reject(new Error('Server responded with a status of ' + req.status)); | |
} else { | |
deferred.resolve(e.target.result); | |
} | |
}; | |
req.send(options.data || void 0); | |
return deferred.promise; | |
} |
Good point, but isn't this something Q should handle internally?
You mean e.target.response
not e.target.result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You should reject with
Error
instances, just like youthrow
with them :)