-
-
Save mattbenic/400e3c039ab8ea3e33aa to your computer and use it in GitHub Desktop.
using System; | |
using System.Net.Mail; | |
using System.Threading; | |
using System.Threading.Tasks; | |
public static class SmtpClientExtensions | |
{ | |
/// <summary> | |
/// Extension method to have SmtpClient's SendMailAsync respond to a CancellationToken | |
/// </summary> | |
public static async Task SendMailAsync( | |
this SmtpClient client, | |
MailMessage message, | |
CancellationToken token) | |
{ | |
Action cancelSend = () => | |
{ | |
client.SendAsyncCancel(); | |
}; | |
using (var reg = token.Register(cancelSend)) | |
{ | |
await client.SendMailAsync(message); | |
} | |
} | |
} |
Does SendMailAsync cancel when SendAsyncCancel is called?
MSDN says "Use the SendAsyncCancel method to cancel a pending SendAsync operation" so I fear that SendAsyncCancel affects SendAsync but not SendMailAsync.
@cwellsx: Looking at the source, SendMailAsync
just wraps SendAsync
, so calling SendAsyncCancel
will work.
Also for what it's worth SmtpClient
is IDisposable
and Dispose
seems to tidy up any in-flight requests. So if you can instantiate your own SmtpClient
(rather than taking an arbitrary one in to your extension method) you can avoid the race condition of calling Register(...SendAsyncCancel)
with something like:
using (var smtpClient = new SmtpClient())
using (cancellationToken.Register(smtpClient.Dispose))
await smtpClient.SendMailAsync("[email protected]", emailAddress, subject, body);
Although now you've got this weird double-dispose thing going on. (Which is harmless, but the method of calling SendAsyncCancel
conveys the intent of what you're doing more clearly, in my opinion.)
Thanks, that's a good suggestion