feedback for tim.md

• project name

  • remove the dot from the repo name to avoid the issue we had
  • remove fr en from Fr_En_Flashcard. to allow for adding new languages or topis in the future

• readme

  • add some screenshoots to readme. or even better have an interactive demo online
  • add installation instructions
  • add instructions on how to add new words

• french_words.csv contains english words, maybe it should be renamed?

• enconding seems to be broken for some words - eg https://github.com/Cistress/Fr_En_Flashcard./blob/main/data/words_to_learn.csv?plain=1#L20

• add some tests

  • try setting up a github action to run them automatically

• add requirements.txt - first tutorial that i found online: https://www.freecodecamp.org/news/python-requirementstxt-explained/

• main.py

  • did you forget to commit the images/ folder?
  • consider splitting it into more than just one file. it's not a must but it's already on the bigg-ish side
  • rename flipping and removing to imperative mood (ie flip, remove). or even better - flip_card, remove_card
  • def next_card(): # next card function here are some visual examples of how this line looks like for me:
    • 
    • 
  • https://github.com/Cistress/Flashcards/blob/11e413f3677706369c5d0110e8e0d0d48c0ab273/main.py#L32C24-L32C25
    • what's d?
    • if those 2 vars are global, let's define them above this function and not when we're flipping the card
    • it doesn't seem like d needs to be global, it's not referenced outside of next_card()