Created
November 27, 2019 22:41
-
-
Save jeremyevans/ffbfc11be96ef4642a79de6b08064123 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/vm_method.c b/vm_method.c | |
index 5637251192..9b34ce17ae 100644 | |
--- a/vm_method.c | |
+++ b/vm_method.c | |
@@ -1769,7 +1769,7 @@ rb_mod_private(int argc, VALUE *argv, VALUE module) | |
* a keyword splat. It marks the method such that if the method is called | |
* with keyword arguments, the final hash argument is marked with a special | |
* flag such that if it is the final element of a normal argument splat to | |
- * another method call, and that method calls does not include explicit | |
+ * another method call, and that method call does not include explicit | |
* keywords or a keyword splat, the final element is interpreted as keywords. | |
* In other words, keywords will be passed through the method to other | |
* methods. | |
@@ -1779,8 +1779,10 @@ rb_mod_private(int argc, VALUE *argv, VALUE module) | |
* 2.7. | |
* | |
* This method will probably be removed at some point, as it exists only | |
- * for backwards compatibility, so always check that the module responds | |
- * to this method before calling it. | |
+ * for backwards compatibility. As it does not exist in Ruby versions | |
+ * before 2.7, check that the module responds to this method before calling | |
+ * it. Also, be aware that if this method is removed, the behavior of the | |
+ * method will change so that it does not pass through keywords. | |
* | |
* module Mod | |
* def foo(meth, *args, &block) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment