JS Regex: Adds thousands separator to a number.

numberWithThousands.js

// Adds the thousands separator
function numberWithThousands(x) {
  return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ".");
}

Not exactly right, numberWithThousands(12234.3242342) will get "12,234.3,242,342".

This works just fine. "1234567.89" turns into "1.234.567.89" due to the separator is ".", replacing it with "," turns the first value to "1,234,567.89"

With "." it works fine, result: 123.456.789
With "," it the result is: 1,2,3,4,5,6,789

Worth noting that for many cases toLocaleString will work just fine:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

Worth noting that for many cases toLocaleString will work just fine:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

how do you cater for users who have English UK or another language in their browser

Worth noting that for many cases toLocaleString will work just fine:
developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

how do you cater for users who have English UK or another language in their browser

If you don't pass a locale parameter, it will get it from the browser.

Thanks but it has failed to work on my browser...
failed to add the thousand seperators
Google Chrome is up to date
Version 74.0.3729.169 (Official Build) (64-bit)

Thanks but it has failed to work on my browser...
failed to add the thousand seperators
Google Chrome is up to date
Version 74.0.3729.169 (Official Build) (64-bit)

Then pass toLocaleString('en-GB')

i think it might be a reactjs problem for not changing the values. Thank you for the help

formatter={(value) => ` ${value}`.replace(/\B(?=(\d{3})+(?!\d))/g, ',')} parser={(value) => value.replace(/\$\s?|(,*)/g, '')}

I'm using this, with the comma works fine but i want to use a dot as a thousand separator and a comma for decimals.
But if i put a dot instead of a comma i get this result 2.0.0.0.0.000 can someone help me?

@OmarNassar01 have a look at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

formatter={(value) => ` ${value}`.replace(/\B(?=(\d{3})+(?!\d))/g, ',')} parser={(value) => value.replace(/\$\s?|(,*)/g, '')}

I'm using this, with the comma works fine but i want to use a dot as a thousand separator and a comma for decimals. But if i put a dot instead of a comma i get this result 2.0.0.0.0.000 can someone help me?

@OmarNassar01 Hi, did you find solution?