Last active
May 5, 2022 16:56
-
-
Save echohack/5059310 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class APIWrapper: | |
#snippet... | |
def poll_api(self, tries, initial_delay, delay, backoff, success_list, apifunction, *args): | |
time.sleep(initial_delay) | |
for n in range(tries): | |
try: | |
status = self.get_status() | |
if status not in success_list: | |
polling_time = time.strftime("%a, %d %b %Y %H:%M:%S", time.localtime()) | |
print("{0}. Sleeping for {1} seconds.".format(polling_time, delay)) | |
time.sleep(delay) | |
delay *= backoff | |
else: | |
return apifunction(*args) | |
except socket.error as e: | |
print("Connection dropped with error code {0}".format(e.errno)) | |
raise ExceededRetries("Failed to poll {0} within {1} tries.".format(apifunction, tries)) |
wouldn't using delay
directly cause the next call to poll_api
use the old value of delay
then?
Oh wait, I think I just answered my own question. No it wouldn't, because delay is immutable.
However, for parameters that are mutable, this could cause a problem I think.
Code updated! Thanks encukou!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You can just use
delay
directly, no need to "make it mutable". In fact, you can never make an int (or float) mutable, but you can assign a completely new object to a variable.The line
delay *= backoff
would create a new immutable number object with valuedelay * backoff
, and then assign that to the namedelay
. The old value ofdelay
is forgotten.