Skip to content

Instantly share code, notes, and snippets.

diff --git a/devtools/client/framework/test/browser_toolbox_options_disable_buttons.js b/devtools/client/framework/test/browser_toolbox_options_disable_buttons.js
--- a/devtools/client/framework/test/browser_toolbox_options_disable_buttons.js
+++ b/devtools/client/framework/test/browser_toolbox_options_disable_buttons.js
@@ -125,7 +125,7 @@ async function testToggleToolboxButtons(
];
// Filter out all the buttons which are not supported on the current target.
- // (WebReplay, DevTools Fission Preferences etc...)
+ // (DevTools Fission Preferences etc...)
const target = await TargetFactory.forTab(gBrowser.selectedTab);
diff --git a/devtools/client/debugger/src/reducers/pause.js b/devtools/client/debugger/src/reducers/pause.js
--- a/devtools/client/debugger/src/reducers/pause.js
+++ b/devtools/client/debugger/src/reducers/pause.js
@@ -30,15 +30,9 @@ import type {
ThreadContext,
Previews,
SourceLocation,
- ExecutionPoint,
} from "../types";
diff --git a/taskcluster/ci/test/test-sets.yml b/taskcluster/ci/test/test-sets.yml
--- a/taskcluster/ci/test/test-sets.yml
+++ b/taskcluster/ci/test/test-sets.yml
@@ -527,7 +527,6 @@ macosx1014-64-tests:
- mochitest-browser-chrome
- mochitest-chrome
- mochitest-devtools-chrome
- - mochitest-devtools-webreplay
- mochitest-gpu
- mochitest-media
diff --git a/taskcluster/taskgraph/transforms/tests.py b/taskcluster/taskgraph/transforms/tests.py
--- a/taskcluster/taskgraph/transforms/tests.py
+++ b/taskcluster/taskgraph/transforms/tests.py
@@ -1293,7 +1293,6 @@ CHUNK_SUITES_BLACKLIST = (
'mochitest-browser-chrome',
'mochitest-browser-chrome-screenshots',
'mochitest-browser-chrome-thunderbird',
- 'mochitest-devtools-webreplay',
'mochitest-plain',
'mochitest-valgrind-plain',
diff --git a/xpcom/ds/nsHashPropertyBag.h b/xpcom/ds/nsHashPropertyBag.h
--- a/xpcom/ds/nsHashPropertyBag.h
+++ b/xpcom/ds/nsHashPropertyBag.h
@@ -32,7 +32,12 @@ class nsHashPropertyBagBase : public nsI
class nsHashPropertyBag : public nsHashPropertyBagBase {
public:
- nsHashPropertyBag() {}
+ nsHashPropertyBag() {
+ // FIXME
diff --git a/devtools/client/debugger/new/test/mochitest/helpers.js b/devtools/client/debugger/new/test/mochitest/helpers.js
--- a/devtools/client/debugger/new/test/mochitest/helpers.js
+++ b/devtools/client/debugger/new/test/mochitest/helpers.js
@@ -1606,7 +1606,7 @@ async function evaluateInTopFrame(target
ok(frames.length == 1, "Got one frame");
const options = { thread: threadClient.actor, frameActor: frames[0].actor };
const response = await consoleFront.evaluateJS(text, options);
- return response.resultGrip;
+ return response.result.type == "undefined" ? undefined : response.result;
}
diff --git a/devtools/client/debugger/new/src/client/firefox.js b/devtools/client/debugger/new/src/client/firefox.js
--- a/devtools/client/debugger/new/src/client/firefox.js
+++ b/devtools/client/debugger/new/src/client/firefox.js
@@ -35,9 +35,7 @@ export async function onConnect(connecti
supportsWasm
});
- if (actions) {
- setupEvents({ threadClient, actions, supportsWasm });
- }
diff --git a/devtools/client/debugger/new/src/client/firefox/commands.js b/devtools/client/debugger/new/src/client/firefox/commands.js
--- a/devtools/client/debugger/new/src/client/firefox/commands.js
+++ b/devtools/client/debugger/new/src/client/firefox/commands.js
@@ -179,9 +179,15 @@ async function setBreakpoint(
location: BreakpointLocation,
options: BreakpointOptions
) {
- breakpoints[locationKey(location)] = { location, options };
- for (const thread of getAllThreadClients()) {
- await thread.setBreakpoint(location, options);
diff --git a/js/src/vm/Probes-inl.h b/js/src/vm/Probes-inl.h
--- a/js/src/vm/Probes-inl.h
+++ b/js/src/vm/Probes-inl.h
@@ -30,7 +30,7 @@ inline bool probes::CallTrackingActive(J
return false;
}
-inline bool probes::EnterScript(JSContext* cx, JSScript* script,
+MOZ_NEVER_INLINE bool probes::EnterScript(JSContext* cx, JSScript* script,
JSFunction* maybeFun, InterpreterFrame* fp) {
@bhackett1024
bhackett1024 / fix-breakpoints
Created February 4, 2019 19:02
apply to debugger.html root to fix breakpoints until changes from devtools-core #1126 are merged
diff --git a/packages/devtools-connection/src/debugger/client.js b/packages/devtools-connection/src/debugger/client.js
index 24e5011..20ca928 100644
--- a/node_modules/devtools-connection/src/debugger/client.js
+++ b/node_modules/devtools-connection/src/debugger/client.js
@@ -3498,12 +3498,12 @@ SourceClient.prototype = {
*
* @param object aLocation
* The location and condition of the breakpoint in
- * the form of { line[, column, condition] }.
+ * the form of { line[, column, options] }.