Skip to content

Instantly share code, notes, and snippets.

@bennyistanto
Last active October 4, 2024 10:59
Show Gist options
  • Save bennyistanto/e17490472251dd7ac6fa8ff55c2b1a38 to your computer and use it in GitHub Desktop.
Save bennyistanto/e17490472251dd7ac6fa8ff55c2b1a38 to your computer and use it in GitHub Desktop.
GEEST 0.1.2 feedback

GEEST2 on QGIS for Windows, LTR 3.34.4-Prizren

Tab: Project

Suggestion

  1. Almost missed the folder icon on the right side πŸ˜ƒ. I think it's better to put it on the left side and below the label Working Directory.
  2. After setting the directory, whenever we close and open it again, the last Working Directory has been set, this is inline with what Tim explain about setting in JSON file.
    I think it would be good if we have a "Reset" button on this page. The function is to make everything like a fresh start and to prevent users from using unwanted folders.
  3. We need to add a NOTE label (with the "i" icon also fine) above the 'Study Area Layer" with the text: Below combo-box will active if you have a polygon (it can be an administrative boundary or just a bounding-box polygon), active as a Layer. If you haven't done so yet, you can add it from the menu editor Layer > Add Layer > Add Vector Layer.

Note

Below combo-box will active if you have a polygon (it can be an administrative boundary or just a bounding-box polygon), active as a Layer.

If you haven't done so yet, you can add it from the menu editor Layer > Add Layer > Add Vector Layer.

  1. Tested using Fiji data, after set the working directory, add the boundary to Layera and set the Study Area Layer and Area Name Field, follow with click Continue button. I understand the process is starting, when I checked the working directory folder, it generates GeoTIFFs and append into GPKG.
    But, I feel empty, something is working at the background, but it's not clear. Adding a progress bar or running text to show the process definitely will help better. I know the progress is available in Log Messages, but it's not interesting for regular user, and usually they never open this window.
    Fiji Combined Mask VRT completed in 11 minutes (using standard laptop), with some warning message:

OGR

2024-10-03T21:04:24     WARNING    Cannot open D:/temp/geest/geest_qgis_templates/output/fji_test_20241003\study_area\study_area.gpkg.()
2024-10-03T21:04:34     WARNING    Cannot find layer study_area_bboxes.()
2024-10-03T21:04:34     WARNING    Cannot find layer study_area_polygons.()

Python

2024-10-03T21:04:34     WARNING    warning:C:\PROGRA~1\QGIS33~1.4\apps\Python39\lib\site-packages\osgeo\ogr.py:596: FutureWarning: Neither ogr.UseExceptions() nor ogr.DontUseExceptions() has been explicitly called. In GDAL 4.0, exceptions will be enabled by default.
              warnings.warn(
             
             traceback: File "C:\Users/benny/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\geest\gui\setup_panel.py", line 254, in on_continue
              processor.process_study_area()
              File "C:\Users/benny/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\geest\core\study_area.py", line 162, in process_study_area
              self.process_multipart_geometry(geom, normalized_name, area_name)
              File "C:\Users/benny/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\geest\core\study_area.py", line 284, in process_multipart_geometry
              self.process_singlepart_geometry(part, part_normalized_name, area_name)
              File "C:\Users/benny/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\geest\core\study_area.py", line 262, in process_singlepart_geometry
              self.create_raster_mask(geom, bbox, normalized_name)
              File "C:\Users/benny/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\geest\core\study_area.py", line 545, in create_raster_mask
              processing.run("gdal:rasterize", params)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\tools\general.py", line 109, in run
              return Processing.runAlgorithm(algOrName, parameters, onFinish, feedback, context)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\core\Processing.py", line 176, in runAlgorithm
              ret, results = execute(alg, parameters, context, feedback, catch_exceptions=False)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\gui\AlgorithmExecutor.py", line 70, in execute
              results, ok = alg.run(parameters, context, feedback, {}, False)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\algs\gdal\GdalAlgorithm.py", line 132, in processAlgorithm
              commands = self.getConsoleCommands(parameters, context, feedback, executing=True)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\algs\gdal\rasterize.py", line 176, in getConsoleCommands
              ogrLayer, layerName = self.getOgrCompatibleSource(self.INPUT, parameters, context, feedback, executing)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\algs\gdal\GdalAlgorithm.py", line 89, in getOgrCompatibleSource
              ogr_layer_name = GdalUtils.ogrLayerName(ogr_data_path)
              File "C:\PROGRA~1/QGIS33~1.4/apps/qgis-ltr/./python/plugins\processing\algs\gdal\GdalUtils.py", line 439, in ogrLayerName
              ds = ogr.Open(basePath)
              File "C:\PROGRA~1\QGIS33~1.4\apps\Python39\lib\site-packages\osgeo\ogr.py", line 7481, in Open
              _WarnIfUserHasNotSpecifiedIfUsingExceptions()
              File "C:\PROGRA~1\QGIS33~1.4\apps\Python39\lib\site-packages\osgeo\ogr.py", line 596, in _WarnIfUserHasNotSpecifiedIfUsingExceptions
              warnings.warn(
  1. Preparing study area is time consuming. The Continue button inactive during the process and back to active after the process completed. To avoid the user click the button again (intentionally or unintentionally), we need to add some additional handling like:
    • Add a label below the Continue button to get the attention, inform that creating study area process has been completed. Re-clicking the button will repeating the previous process which took a lot of time.
    • After the process completed, and button Continue active again, then Active Tab should change into Inputs. User can go back to Tab Project, and will found information from previous point "Capital label with the information"

Warning

Creating study area process has been completed. Re-clicking the button will repeating the previous process which took a lot of time.

Error

  1. Working Directory has been set. After clicked the button Add World Map, an Error message popup with message: Could not find world map file at C:/PROGRA~1/QGIS33~1.4/apps/qgis-ltr\share\qgis\resources\data\world_map.gpkg.
    I understand this error not related to the plugin. But what if the user experience this? How to solve it?

Tab: Inputs

Feature on Right-click menu

Right-click menu Factors Variables Data Layers
Clear Factor Weightings βœ“
Clear Layer Weightings βœ“
Auto Assign Factor Weightings βœ“ βœ“
Show Attributes βœ“ βœ“ βœ“
Add to Map βœ“ βœ“ βœ“
Edit Aggregation βœ“
Show Properties βœ“
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment