Skip to content

Instantly share code, notes, and snippets.

View JorikSchellekens's full-sized avatar

mempoolsurfer JorikSchellekens

View GitHub Profile
# Appendix
The following sections contain reference material you may find useful in your
Cairo journey.
# Appendix
The following sections contain reference material you may find useful in your
Starknet journey.
# Appendix A - Keywords
# Appendix
The following sections contain reference material you may find useful in your
Cairo journey.
# Appendix A - Keywords
The following list contains keywords that are reserved for current or future use by the Cairo language.
There are three keyword categories:
  1. Global configuration + AToken
  2. AaveProxy
  3. PoolAddressesProvider
  4. PoolAddressesProviderRegistry
  5. ACLManager
  6. Reserve
    1. AToken
      1. IncentivizedERC20
      2. MintableIncentivizedERC20
  7. ScaledBalanceToken
@JorikSchellekens
JorikSchellekens / Lyricist - Fix lyrics view on playlists.md
Last active January 9, 2019 12:49
Lyricist proposal for fixing issue 10

Fix lyrics view on playlists.

This is a simple proposal to fix issue #10.

The current lyrics view is injected into the DOM as the first child of the DOM element indicated by selector LYRIC_LOCATION_SELECTOR defined in constants.js. The selector is currently set to the top of the suggested videos.

Solution

A simple and aesthetically pleasing solution would be to put the lyrics above the playlist. Showing at the same width. Much as it is when the song playing is not in a playlist.

Lyricist lyric injection bugfix

The current extension cycle is triggered by an event listener on onUpdate over all the tabs. The event is then broadcast to the extension with the TAB_CHANGED id. If a lyrics view is currently present it is removed and then the metadata of the song is fetched, the lyrics fetched and then inserted into the #related div.

As follows: