Last active
March 21, 2018 13:01
Test example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <?php namespace App; | |
| class Developers | |
| { | |
| function get_best_developer($type) | |
| { | |
| if ($type == 1) { // VueJs | |
| $developer = 'John Smith'; | |
| } elseif ($type == 2) { // Laravel | |
| $developer = 'Andrew'; | |
| } elseif ($type == 3) { // Servers | |
| $developer = 'Maria'; | |
| } elseif ($type == 4) { // Sympfony | |
| $developer = 'Max'; | |
| } | |
| return $developer; | |
| } | |
| } |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A pull request is made from the branch feature-developer-finder to dev. You will make a code review. The code above is written by a very junior developer, and your task is to give him tips on how this can be improved. What do you say to him?